alvierahman90/qmk_firmware
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
12,381 Commits 48 Branches 349 Tags 167 MiB
4597f2bcc8
Commit Graph

12381 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
IFo Hancroft
78e060f55a
VIA Support for the Idobo (ID75) (#8146) 
* VIA Support for the Idobo (ID75)

* Implemented the requested PR changes

* Readme was pointing to the wrong board

* Fixed Product ID

* Fixed Manufacturer name

* Better Vendor ID

Using the two 8-bit ASCII values from the keyboard name.

* Removed Bootmagic Lite as enabled anyway by VIA
 2020-02-11 12:44:09 -08:00
MechMerlin
c53d4ecf32
VIA Support: Duck Eagle V2 (#8133) 
* add via keymap

* Update keyboards/duck/eagle_viper/v2/keymaps/via/keymap.c
 2020-02-11 10:07:06 -08:00
ymzcdg
6a165c41cb
[Docs] doc update zh-cn (#8147) 
* update zh-cn translate

Timestamp was added at the end of the document, it can help me manage version easier.

* fix _summary.md to utf-8

* fix _summary.md with vscode
 2020-02-11 10:05:23 -08:00
Jonathan Rascher
387c486e57
Rename Polaris Tsangan layout to 60_tsangan_hhkb and enable community layout support (#8144) 
* Rename Polaris Tsangan layout to 60_tsangan_hhkb
 2020-02-11 09:47:16 -08:00
a_p_u_r_o
a624c439a4
[Keyboard] Fixed inconsistent MATRIX_ROWS and MATRIX_COLS: wsk/gothic50 (#8150) 2020-02-11 15:02:18 +00:00
Joel Challis
fba9971555
Align max backlight level in docs (#8142) 2020-02-11 14:59:58 +00:00
Mikkel Jeppesen
310b2f1be4
use replace() over rename() to have cross-platform overwriting (#8148) 2020-02-11 10:37:15 +01:00
Jonathan Rascher
1fed214490
Tweak my TAPPING_TERM and be more futureproof (#8143) 
* Explicitly undef things I override in keymaps

* Reduce TAPPING_TERM back to default
 2020-02-11 03:11:09 +00:00
dnsnrk
f4c1e066ba
[Keymap] User keymap for KBDfans KBD67 MKII RGB (hot-swap) (#7697) 
* initial custom keymap

* initial code for caps lock LED

* added debounce overrides

* override caps lock handler

* finished up on CAPS LOCK LED customization

* lowered debounce

* layer lightning fx

* Added layer tap-toggle

* reformatting

* refined keymap

* copyright and more clean-up

* increased DEBOUNCE

* initial custom keymap

* initial code for caps lock LED

* added debounce overrides

* override caps lock handler

* finished up on CAPS LOCK LED customization

* lowered debounce

* layer lightning fx

* Added layer tap-toggle

* reformatting

* refined keymap

* copyright and more clean-up

* increased DEBOUNCE

* added readme and some more clean-up

* incorporated pull request feedback
 2020-02-10 18:05:25 -08:00
a_p_u_r_o
4b7d46ced0
[Keyboard] Use DIRECT_PINS instead of empty MATRIX_ROW_PINS: sixshooter (#8130) 
* [Keyboard] Use DIRECT_PINS instead of empty MATRIX_ROW_PINS: sixshooter

* [Keyboard] Reform the matrix into 2x3: sixshooter
 2020-02-10 17:22:37 -08:00
James Young
cabe4dfa72
[Keyboard] VIA Support for Boardwalk (#8124) 
* initial commit of VIA Support

* update PRODUCT (and MANUFACTURER) per VIA docs

Reference: https://caniusevia.com/docs/configuring_qmk#change-product

Updated MANUFACTURER so it matches what the PRODUCT says.

* enable Link Time Optimization per mechmerlin

* revert change to USB Product Name

* add two empty layers to via keymap

VIA keymaps need four layers in flash.

* correct the layer indexes

Start from 0, not 1.
 2020-02-10 17:14:19 -08:00
Joel Challis
5279571e41
Remove zvecr dz60 keymap (#8140) 2020-02-10 12:58:55 -08:00
Nick Brassel
9398c11b51
Remove tzarc's Luddite keymap. (#8139) 2020-02-10 12:52:40 -08:00
Josh Johnson
89c528e443
[Keyboard] Add support for Hub16 (#7794) 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
 2020-02-10 14:16:27 +01:00
ai03
8f333138f5 [Keyboard] Add support for Polaris (#8123) 
* Drop in old files

* Make a blank template keyboard to refresh ancient files to latest config

* Update keymaps files to new format

* Remove chunks of config asked for removal in previous pullreqs

* Remove split pin option from config

* Update rules.mk to latest version

* Remove unused functions from polaris.c

* Add via keymap

* Build basic tsangan keymap; add QMK configurator info

* Remove temporary template

* Update keyboards/ai03/polaris/config.h

* Update keyboards/ai03/polaris/readme.md

* Update keyboards/ai03/polaris/readme.md

* Update keyboards/ai03/polaris/readme.md

* Update rules.mk

* Fixes as per pullreq

* Update keyboards/ai03/polaris/keymaps/default_ansi_tsangan/keymap.c

* Update keyboards/ai03/polaris/polaris.h

* Update keyboards/ai03/polaris/keymaps/default_ansi_tsangan/keymap.c

* Update keyboards/ai03/polaris/info.json

* Update keyboards/ai03/polaris/keymaps/testing/readme.md
 2020-02-10 00:53:16 -08:00
madhogs
35c4dbe688 New iso layout and keymap for dz60 with 4th row all 1u (#7830) 
* Added new iso layout and keymap for dz60 with all 4th row keys 1u in size
 2020-02-09 23:53:12 -08:00
Ted Lin
c3200aa8fc Compile error if ONESHOT_TIMEOUT defined but oneshot disabled (#8100) 
* Compile error if ONESHOT_TIMEOUT defined but oneshot disabled

When ONESHOT_TIMEOUT and NO_ACTION_ONESHOT are both defined, this code
fails to compile.

Wrap the one usage of ONESHOT_TIMEOUT that is inconsistent with the
rest so all usages are properly wrapped by a check of NO_ACTION_ONESHOT.

* Run file through clang-format

Co-authored-by: Ted M Lin <tedmlin@gmail.com>
 2020-02-10 04:50:45 +00:00
fauxpark
6052aa499e
Use FIRMWARE_FORMAT for "Checking file size" message (#8121) 2020-02-10 04:19:08 +11:00
nopunin10did
2fe288d01d
[Keymap] Adding ergodash/rev1:nopunin10did (#8098) 
* Adding ergodash/rev1:nopunin10did

* Update keyboards/ergodash/rev1/keymaps/nopunin10did/keymap.c

* Update keyboards/ergodash/rev1/keymaps/nopunin10did/keymap.c

* Update keyboards/ergodash/rev1/keymaps/nopunin10did/readme.md
 2020-02-08 19:54:10 -08:00
Erovia
b6e23f974b
Update the flash cli command to use the user config (#8125) 2020-02-08 23:58:28 +01:00
fauxpark
174a15d07d Remove PJRC USB stack 2020-02-08 11:07:43 -08:00
James Young
5ab0eeb513
[Keyboard] Boardwalk Refactor (#8122) 
* refactor keymaps

Create one keymap for each layout macro.

* remove config.h for default keymap

There's nothing in it.

* update readme

- use the new list format
- use a smaller version of the keyboard photo (does the readme really need a 14MP image on it?)
 2020-02-08 10:25:50 -08:00
Joel Challis
75e7018f72 CI: Add workflow for CLI testing (#7357) 
Create GitHub Actions cli test workflow and remove travis runs of 'qmk pytest'
 2020-02-08 13:43:55 +01:00
holtenc
8fe29f2784 Add Prime_L V2 and Prime_EXL Plus (#8111) 
* correct indicator light states.

function of indicator lights was inverted. these changes correct that.

* flesh out keymaps pre production

* Enable extrakey in rules

* Prime_BLE initial commit

* Initial commit for Prime_L V2

* Update info.json

correct key spacing.

* update copyright

* Update readme.md

* Inital commit

* updates before PR into QMK master

* Drop Prime_EXL Plus from PR. Make requested changes to Prime_L V2

* Rename keyboards/primekb/Prime_l_v2/config.h to keyboards/primekb/prime_l_v2/config.h

* Rename keyboards/primekb/prime_l_v2/config.h to keyboards/primekb/Prime_l_v2/config.h

* remove directory Prime_l_v2

* re-submit with proper folder name.
 2020-02-08 15:03:44 +11:00
worldspawn00
dd6f92541d
[Keyboard] adding keyboard: neuron (#7980) 
* neuron

* Update keyboards/walletburner/neuron/neuron.h

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/walletburner/neuron/neuron.h

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/walletburner/neuron/config.h

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/walletburner/neuron/config.h

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/walletburner/neuron/config.h

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/walletburner/neuron/readme.md

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Update keyboards/walletburner/neuron/readme.md

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Update keyboards/walletburner/neuron/readme.md

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Committed review suggestions

* Corrected bootloader to use atmel-dfu

* One last tweak to correct MANUFACTURER

Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
 2020-02-07 19:42:29 -08:00
worldspawn00
610cf729af [Keyboard] adding keyboard: pain27 (#7977) 
* pain27

* Applied review suggestions

* Correct DEBOUNCE verbiage, remove .ini files

* Readme tweaks

Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
 2020-02-07 19:42:03 -08:00
worldspawn00
96a4388c43 [Keyboard] adding keyboard: sl40 (#7978) 
* sl40

* Amended with collaborator suggestions

Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
 2020-02-07 19:39:44 -08:00
worldspawn00
a86a8a236a
[Keyboard] adding keyboard: houndstooth (#7981) 
* houndstooth

* Amended with collaborator suggestions

* LAYOUT fixup, left crud in keymap

* Fix missing comma in keymap.c

* Correct RGBLIGHT_ENABLE to no

Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
 2020-02-07 19:38:20 -08:00
worldspawn00
f44a89ca77
[Keyboard] adding keyboard: kodachi50 (#7976) 
* kodachi50

* Amendeded with collaborator suggestions

* Add a missing key to layer 2 top row

Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
 2020-02-07 19:37:46 -08:00
worldspawn00
a1a88b8ac7
[Keyboard] adding keyboard: gothic70 (#7982) 
* gothic70

* Update keyboards/wsk/gothic70/readme.md

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Update keyboards/wsk/gothic70/readme.md

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Update keyboards/wsk/gothic70/readme.md

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Update keyboards/wsk/gothic70/keymaps/default/keymap.c

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Update keyboards/wsk/gothic70/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic70/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic70/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic70/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic70/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic70/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic70/config.h

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic70/keymaps/default/keymap.c

Co-Authored-By: Mikkel Jeppesen <2756925+Duckle29@users.noreply.github.com>

* Update keyboards/wsk/gothic70/keymaps/default/keymap.c

Co-Authored-By: Mikkel Jeppesen <2756925+Duckle29@users.noreply.github.com>

* Update keyboards/wsk/gothic70/keymaps/default/keymap.c

Co-Authored-By: Mikkel Jeppesen <2756925+Duckle29@users.noreply.github.com>

* Update keyboards/wsk/gothic70/keymaps/default/keymap.c

Co-Authored-By: Mikkel Jeppesen <2756925+Duckle29@users.noreply.github.com>

* Update keyboards/wsk/gothic70/keymaps/default/keymap.c

Co-Authored-By: Mikkel Jeppesen <2756925+Duckle29@users.noreply.github.com>

* Update keyboards/wsk/gothic70/keymaps/default/keymap.c

Co-Authored-By: Mikkel Jeppesen <2756925+Duckle29@users.noreply.github.com>

* Update keyboards/wsk/gothic70/config.h

Co-Authored-By: Mikkel Jeppesen <2756925+Duckle29@users.noreply.github.com>

* Update keyboards/wsk/gothic70/keymaps/default/keymap.c

Co-Authored-By: Mikkel Jeppesen <2756925+Duckle29@users.noreply.github.com>

* Update keyboards/wsk/gothic70/keymaps/default/keymap.c

Co-Authored-By: Mikkel Jeppesen <2756925+Duckle29@users.noreply.github.com>

* Update keyboards/wsk/gothic70/keymaps/default/keymap.c

Co-Authored-By: Mikkel Jeppesen <2756925+Duckle29@users.noreply.github.com>

* Committed review suggestions

* Small indicator LED layer function tweak

* Fixing layout for configurator

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: Mikkel Jeppesen <2756925+Duckle29@users.noreply.github.com>
 2020-02-07 19:34:37 -08:00
worldspawn00
df029f9660 [Keyboard] adding keyboard: gothic50 (#7983) 
* gothic50

* Update keyboards/wsk/gothic50/config.h

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic50/config.h

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic50/config.h

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic50/config.h

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic50/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic50/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic50/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic50/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic50/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Update keyboards/wsk/gothic50/keymaps/default/keymap.c

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Update keyboards/wsk/gothic50/readme.md

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Update keyboards/wsk/gothic50/readme.md

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Update keyboards/wsk/gothic50/readme.md

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Update keyboards/wsk/gothic50/rules.mk

Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com>

* Updated with collaborator suggestions

* Fixing layout for configurator

Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
 2020-02-07 19:32:14 -08:00
James Young
b62829031d [Keyboard] YMDK NP21: matrix and keymap refactor (#8112) 
* YMDK NP21: matrix and keymap refactor

- refactored layout macros
  - LAYOUT_ortho_6x4 orients the keyboard with the USB port to the back instead of to the right
  - LAYOUT uses the previous sideways orientation (included for backwards compatibility)
- removed redundant includes from ymdk_np21.h
- added a readme for the default keymap

* add Configurator layout support
 2020-02-07 19:15:35 -08:00
Mehmet Denizhan Erdem
43c0a9293e [Keymap] Added keymap for keebio/nyquist (#8108) 
* my custom keymap for nyquist rev3

* Formatted keymap and added readme
 2020-02-07 19:07:04 -08:00
Joel Challis
4962b743d2
[Keyboard] Port SPLIT_USB_DETECT to lily58 (#8107) 
* remove unused files

* Port SPLIT_USB_DETECT to lily58
 2020-02-07 19:03:51 -08:00
Max Rumpf
ea2fcb5b08
[Keymap] Phoebe/Maxr1998 keymap: enable space cadet with curly braces (#8096) 
* Phoebe/Maxr1998 keymap: enable space cadet with curly braces

* Revert space cadet for left shift, open curly brace on right shift
 2020-02-07 18:54:41 -08:00
Yasuhiro SHIMIZU
fd2ac4b4d5
[Keymap] add lily58 yshrsmz keymap (#8095) 
* add lily58 yshrsmz keymap

* apply requested changes

* remove more backslashes

* remove more backslashes

* update rules.mk
 2020-02-07 18:53:53 -08:00
esinlayo
7182e9a8ad
[Keyboard] Remove i2c write command when reading columns on Ergodox EZ (#8092) 
* Remove i2c write command when reading cols on Ergodox EZ

* Comment on mcp23018 address state during read_cols
 2020-02-07 18:52:02 -08:00
fauxpark
3b1f29a5d6
[Keyboard] Misc tidyups for Chidori (#8091) 2020-02-07 18:50:42 -08:00
Alfred Maler
707c04b4ab
[Keymap] Add users/alfrdmalr and switch to layouts (#8030) 
* WIP do not merge

* first pass at custom preonic layout

* add auto shift and reset via leader key

* Update readme

* update copyright notice

* formatting changes

* fix: use MO instead of process_record_user

* added backslash and moved grave position

* remove extraneous 'j' characer in NUMPAD template

* update template formatting

* remove process_record_user

* swap "!" with "@"

* fix readme formatting

* update readme layout image

* restore settings layer

* add windows minimize sequence

* fix: switch to correct seq function for three-key sequence

* fix: missing semicolon

* refactor: move keymap to userspace and generic 5x12 layout

* add numlock to numpad layer

* add readme

* update readme formatting

* remove unused wrappers from layout keymap

* update readme title to reflect new location

* remove alfrdmalr directory from preonic/keymaps

* clean up user config
 2020-02-07 18:42:04 -08:00
James Young
be05de6a3d
XD84: Configurator bugfix for ISO layout (#8117) 
* switch to debug linting

* move ISO Enter to its proper location
 2020-02-07 18:16:44 -08:00
James Young
889eb51fb5
ZJ68: complete Configurator layout support (#8116) 
Only LAYOUT_all had its layout data present; the data for LAYOUT_65_ansi and LAYOUT_65_ansi_split_bs was missing.
 2020-02-07 18:09:55 -08:00
Cody Bender
e77188458f
Add QMK Compile Context Sensitivity (#6884) 
* Add context sensitive compile, without config check

* Initial full working state. Plan to refactor

* Refactor loop for simplicity, add comments

* Update docs/cli.md with qmk compile examples

* Simplify path for keyboard derivation

* Update path to use path.join instead of concat

* Refactor keyboard path, the skully way

* Add in keymap folder support

* Add /layouts compile support

* Update docs/cli.md with empty compile in layouts

* Add comments to compile.py

* Update docs for clarity, and fix compile error typo

* Fix config option compile

* Fix layout compile and failure mode

* Add rules.mk check

* Fix variable names for global config

* Add in_layout priority

* Remove default fallback in favor of throw, update docs

* Add keymap folder context

* Fix formatting

* Add os import

* Convert to create_make_command

* Fix Travis lint errors

* Remove blank line with whitespace

* Add blank lines for readability

* Remove unnecessary config logic

* Update Docs to add flash

Co-Authored-By: skullydazed <skullydazed@users.noreply.github.com>

* Shift config precedence to MILC

Co-authored-by: skullydazed <skullydazed@users.noreply.github.com>
 2020-02-07 21:48:37 +01:00
Joel Challis
774cbbf879
Refactor ergo42 to use split_common (#7925) 
* Initial refactor of ergo42 to split common

* Prevent fallthrough for DIODE_DIRECTION
 2020-02-07 13:59:18 +00:00
Joel Challis
c93093569e
Refactor mint60 to use split_common (#8084) 2020-02-07 13:58:55 +00:00
Marius Rugan
fb6f581157
jj4x4: README update (#7854) 
* Updates README jj4x4

* Update keyboards/jj4x4/README.md

* Update keyboards/jj4x4/README.md

* Update keyboards/jj4x4/README.md

* Update keyboards/jj4x4/README.md

* Update keyboards/jj4x4/README.md
 2020-02-07 02:13:53 -08:00
worldspawn00
e43d143ab0
[Keyboard] adding keyboard: tkl30 (#7979) 
* tkl30

* Amended with collaborator suggestions

* s/DEBOUNCING_DELAY/DEBOUNCE/

* Used noroadsleft's PID suggestion

* Committed noroadsleft's keymap formatting and rules.mk suggestions

* LAYOUT formatting and readme suggestions
 2020-02-06 21:28:08 -08:00
fauxpark
a73c38112d
Move Grave Escape, Lock and Leader keycodes into their own sect… (#8093) 2020-02-07 15:54:14 +11:00
ridingqwerty
e3444084fb
Committing fix to info.json for wsk/jerkin (#8110) 2020-02-06 21:58:16 -05:00
Ted M Lin
d84eb14b3a
Use function for KEYCODE2 routines instead of macro. (#8101) 
* Option to use function for KEYCODE2 routines.

Convert the KEYCODE2SYSTEM and KEYCODE2CONSUMER macros to functions,
defaulting to using the macros.  The function form allows the compiler
to optimize the switch statement itself, over the macro nested
ternaries.

To enable this feature, #define USE_KEYCODE2_FUNCTION.

Testing against a random selection of avr-based keyboards, this
increased available flash by ~500 bytes. For arm-based keyboards,
the available flash increased by ~400 bytes.

* Replace macro with function entirely.

As zvecr states, go bold and just commit to using the function instead
of the macro.

* Reformat whitespace now that functional review is done

Verified against clang-format output.
 2020-02-07 12:53:43 +11:00
worldspawn00
fe814be287
[keyboard] adding keyboard: jerkin (#7975) 
* jerkin

* Update config.h

* Apply suggestions from code review

Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: Akaash Suresh <casa.akaash@gmail.com>

* Update rules.mk

* Apply suggestions from code review

* Missing closing parenthesis in one of the suggestions.

* Finalize collaborator suggestions

* One final tweak to standardize MANUFACTURER

Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Akaash Suresh <casa.akaash@gmail.com>
 2020-02-06 10:55:55 -05:00